Avoid default IP of 0.0.0.0 #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This default never makes sense, since a connection request to the 0 IP always fails. The Option mechanism provides a better way of setting an unknown that can easily be detected than abusing a valid but useless IP address.
|
Let's see if we agree this time :) |
|
Like that, I am ok with your change. |
|
Saw it in our logs, tracked it in code, fixed it in code, then realized that we are causing it ourselves and also fixed it in the environment of how it's run. |
|
In this case it was caused by using a tcp livenessProbe in kubernetes. Though I think it would generally happen if something tried to send a request directly instead of the CONNECT http verb, which is a more likely mistake people might make. |
|
Alright :) Thank you for the contribution, it is really appreciated ! |
jmars
pushed a commit
to jmars/wstunnel
that referenced
this pull request
Dec 23, 2024
This default never makes sense, since a connection request to the 0 IP always fails. The Option mechanism provides a better way of setting an unknown that can easily be detected than abusing a valid but useless IP address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This default never makes sense, since a connection request to the 0 IP always fails.
The Option mechanism provides a better way of setting an unknown that can easily be detected than abusing a valid but useless IP address.